Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hirad/Mobile active language update issue #5132

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Hirad/Mobile active language update issue #5132

merged 3 commits into from
Apr 27, 2022

Conversation

hirad-deriv
Copy link
Contributor

Changes:

Please include a summary of the change and which issue is fixed below:

  • ...

When you need to add unit test

  • If this change disrupt current flow
  • If this change is adding new flow

When you need to add integration test

  • If components from external libraries are being used to define the flow, e.g. @deriv/components
  • If it relies on a very specific set of props with no default behavior for the current component.

Test coverage checklist (for reviewer)

  • Ensure utility / function has a test case
  • Ensure all the tests are passing

Type of change

  • Bug fix
  • New feature
  • Update feature
  • Refactor code
  • Translation to code
  • Translation to crowdin
  • Script configuration
  • Improve performance
  • Style only
  • Dependency update
  • Documentation update
  • Release

@boring-cyborg boring-cyborg bot added the Core label Mar 30, 2022
@vercel
Copy link

vercel bot commented Mar 30, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/deriv/deriv-app/D8P1SwiiQf9QMTkXbNKjvgUKuw9Z
✅ Preview: https://deriv-app-git-fork-hirad-rewok-mobile-activelanguage-upd-abe47d.binary.sx

@github-actions
Copy link
Contributor

github-actions bot commented Mar 30, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/deriv-app/pull/5132](https://github.com/binary-com/deriv-app/pull/5132)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-hirad-rewok-mobile-activelanguage-upd-abe47d.binary.sx?qa_server=frontend.binaryws.com&app_id=31481
    - **Original**: https://deriv-app-git-fork-hirad-rewok-mobile-activelanguage-upd-abe47d.binary.sx
- **App ID**: `31481`

@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@farrah-deriv farrah-deriv merged commit 77861e5 into deriv-com:master Apr 27, 2022
sandeep-deriv pushed a commit to sandeep-deriv/deriv-app that referenced this pull request Apr 29, 2022
@hirad-deriv @sandeep-deriv
Hirad/Mobile active language update issue (deriv-com#5132)
48725f5 
* Mobile language menu does not update active language

* Get language is added to the component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamin-deriv alamin-deriv alamin-deriv approved these changes

@akmal-deriv akmal-deriv akmal-deriv approved these changes

@matin-deriv matin-deriv matin-deriv approved these changes

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

Assignees
No one assigned
Labels
Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hirad-deriv @matin-deriv @akmal-deriv @alamin-deriv @farrah-deriv